Skip to content

feat: [Tolk] Migration from FunC #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2025
Merged

feat: [Tolk] Migration from FunC #1093

merged 3 commits into from
Nov 7, 2025

Conversation

@aigerimu
Copy link
Contributor

@aigerimu aigerimu commented Nov 4, 2025

closes #1039

@aigerimu aigerimu marked this pull request as draft November 4, 2025 16:17
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore languages/tolk-vs-func/in-detail.mdx languages/tolk-vs-func/in-short.mdx languages/tolk-vs-func/mutability.mdx languages/tolk-vs-func/stdlib.mdx

github-actions[bot]
github-actions bot reviewed Nov 4, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update—across languages/tolk-vs-func, there are several suggestions; please apply the inline suggestions.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore languages/tolk-vs-func/in-detail.mdx languages/tolk-vs-func/in-short.mdx languages/tolk-vs-func/mutability.mdx languages/tolk-vs-func/stdlib.mdx

@aigerimu aigerimu marked this pull request as ready for review November 5, 2025 19:08
github-actions[bot]
github-actions bot reviewed Nov 5, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates — I reviewed changes under languages/tolk-vs-func/. I’ve left several suggestions; please apply the inline suggestions to address wording and example syntax.

verytactical
verytactical requested changes Nov 6, 2025
View reviewed changes
@verytactical verytactical marked this pull request as draft November 6, 2025 08:09
@aigerimu aigerimu mentioned this pull request Nov 6, 2025
Open
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore languages/tolk/vs-func/in-detail.mdx languages/tolk/vs-func/in-short.mdx languages/tolk/vs-func/mutability.mdx languages/tolk/vs-func/stdlib.mdx languages/tolk/tolk.mdx

@aigerimu aigerimu marked this pull request as ready for review November 6, 2025 11:21
github-actions[bot]
github-actions bot reviewed Nov 6, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. In languages/tolk/vs-func/in-detail.mdx:, I’ve left several suggestions; please apply the inline suggestions.

@anton-trunov
Copy link
Collaborator

anton-trunov commented Nov 6, 2025

/review

github-actions[bot]
github-actions bot reviewed Nov 6, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates—reviewed changes under languages/tolk. There are several suggestions below; please apply the inline suggestions.

languages/tolk/from-func/in-detail.mdx
Comment on lines +32 to +35
```tolk
var cell = ...
var cell: cell = ...
```
Copy link

@github-actions github-actions bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Literal ellipses used in code examples (copy/paste hazard)

The code block uses ... to indicate omitted code, which changes syntax and makes snippets non‑runnable. The style guide requires using language‑appropriate comments to mark omissions instead of literal ellipses. See Comments and omissions (https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L532-L535). Similar patterns occur elsewhere (e.g.,

docs/languages/tolk/vs-func/in-short.mdx

Lines 24 to 36 in dc05e7e

fun parseData(cs: slice): cell {
var flags: int = cs.loadMessageFlags();
...
}
@inline
fun sum(a: int, b: int) { // auto inferred int
val both = a + b; // same
return both;
}
get fun currentCounter(): int { ... }
```
,

docs/languages/tolk/vs-func/mutability.mdx

Lines 210 to 224 in dc05e7e

fun increment(mutate x: int): void { ... }
// does: (x', _) = increment(x); x = x'
increment(mutate x);
// returns (int, int, (slice, cell))
fun f2(mutate x: int, mutate y: int): (slice, cell) { ... }
// does: (x', y', r) = f2(x, y); x = x'; y = y'; someF(r)
someF(f2(mutate x, mutate y));
// when `self`, it's the same
// does: (cs', r) = loadInt(cs, 32); cs = cs'; flags = r
flags = cs.loadInt(32);
```
) as corroborating evidence.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

@aigerimu
Copy link
Contributor Author

aigerimu commented Nov 7, 2025

/review

github-actions[bot]
github-actions bot reviewed Nov 7, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates—I've queued several suggestions in languages/tolk/vs-func. Please apply the inline suggestions.

languages/tolk/from-func/in-detail.mdx
If omitted, it's auto-inferred:

```tolk
fun x() { ... } // auto infer from return statements
Copy link

@github-actions github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Literal ellipses used inside fenced code

The example uses ... as a placeholder in code, violating the rule to avoid literal ellipses that change syntax and produce non-runnable examples. Convert to a comment while preserving the explanatory trailing comment. See https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L532-L535.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

languages/tolk/from-func/in-short.mdx
return both;
}

get fun currentCounter(): int { ... }
Copy link

@github-actions github-actions bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Literal ellipses used inside fenced code

A single-line function stub includes ... inside code, which changes syntax and renders the snippet non-runnable. The style guide requires using comments to mark omitted code, not literal ellipses. See https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L532-L535.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

anton-trunov
anton-trunov reviewed Nov 7, 2025
View reviewed changes
anton-trunov
anton-trunov reviewed Nov 7, 2025
View reviewed changes
anton-trunov
anton-trunov reviewed Nov 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

To fix the formatting issues:

  1. Install necessary dependencies: npm ci
  2. Then, run this command:
npx remark -o --silent --silently-ignore languages/tolk/from-func/in-detail.mdx languages/tolk/from-func/in-short.mdx languages/tolk/from-func/mutability.mdx languages/tolk/from-func/stdlib.mdx languages/tolk/overview.mdx

Your Name added 2 commits November 7, 2025 16:50
@anton-trunov anton-trunov merged commit 24b77cd into main Nov 7, 2025
5 checks passed
@anton-trunov anton-trunov deleted the mogration-to-tolk branch November 7, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@verytactical verytactical verytactical requested changes

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tolk] Migration from FunC

4 participants

@aigerimu @anton-trunov @verytactical